SOLR-18014: Improve filestore "getFrom" validation #3925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helps add clarity to an internal API, and protects against client code accidentally fetching files from an unintended Solr cluster, etc.
gerlowskija
changed the title
gerlowskija
changed the title
epugh
approved these changes
Dec 5, 2025
Contributor
epugh
left a comment
epugh
left a comment
There was a problem hiding this comment.
Just a lovely set of code changes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18014
Description
Our file store implementation has an internal API used to fetch filestore files from other nodes in the cluster. A specific node in the cluster can be specified as the source to pull from using the "getFrom" query parameter. But nothing actually validates the provided "getFrom" value or ensures it's another node in the cluster.
Solution
This PR checks the value of "getFrom" when provided and ensures it is a known live node.
Tests
Additional scenario added to TestDistribFileStore to exercise the error message.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.