SOLR-18036 Auto migrate log4j2.xml docker #3958
Open
+170
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janhoy
commented
Dec 17, 2025
dsmiley
approved these changes
Dec 18, 2025
Contributor
dsmiley
left a comment
dsmiley
left a comment
There was a problem hiding this comment.
Looks good. Albeit I wonder if not installing log4j2.xml there in the first place would be no more work than this work-around/fix.
Contributor
Author
I think this auto-migration strategy can stay in place even if we remove the auto-copy part later. Will merge soon. |
janhoy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18036
This fix will conditionally
s/solr.log.dir/solr.logs.dir/in/var/solr/log4j2.xml, but only ifsolr.log.dirIf these are not true, nothing happens.
If they are true but editing the file fails, e.g. due to read-only file system, a warning message is written to stderr.