Skip to content

Add clean to cherrypick.sh before runnign (precommit) check#4238

Open
janhoy wants to merge 1 commit intoapache:mainfrom
janhoy:cherry-pick-add-clean
Open

Add clean to cherrypick.sh before runnign (precommit) check#4238
janhoy wants to merge 1 commit intoapache:mainfrom
janhoy:cherry-pick-add-clean

Conversation

@janhoy
Copy link
Contributor

@janhoy janhoy commented Mar 25, 2026

If not doing this, old build directories on disk may cause false test failures, such as detecting broken links in old stale javadoc, which is not a problem if re-built.

I had a cherry pick abort with below message, but turned out it was checking stale javadoc...

> Task :solr:documentation:checkBrokenLinks FAILED
Broken links check failed. First lines of the output:

Crawl/parse...

Verify...

file:///Users/janhoy/git/solr2/solr/documentation/build/site/modules/llm/overview-tree.html
  BROKEN LINK: file:///Users/janhoy/git/solr2/solr/documentation/build/site/core/org/apache/solr/search/neural/AbstractVectorQParserBase.html
  BROKEN LINK: file:///Users/janhoy/git/solr2/solr/documentation/build/site/core/org/apache/solr/search/neural/KnnQParser.html
[...]

Copy link
Contributor

@epugh epugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't use the script everytime, but I do anytime it's more then the most minor change, and so this makes sense even if it makes things take longer! Cause I am using it for a more meaty backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants