Repository navigation
[SPARK-60068] Run unit tests on each matrix JDK and skip linters in build-test CI - #956
Closed
dongjoon-hyun wants to merge 1 commit into
Closed
dongjoon-hyun wants to merge 1 commit into
dongjoon-hyun wants to merge 1 commit into
Conversation
Member
Author
|
Since this is a CI-only patch, let me merge this to improve JDK coverage. |
Member
Author
|
Merged to main |
Contributor
|
Late LGTM. |
Member
Author
|
Thank you always, @peter-toth ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to run the
build-testCI unit tests on each matrix JDK (21 / 25 / 26 / 27) instead of repeating the full build in every leg.-PtestJavaVersion=<N>, to run thetesttasks on JDK<N>. Compilation still uses the JDK 27 toolchain../gradlew test -PtestJavaVersion=${{ matrix.java-version }}instead of./gradlew buildin thebuild-testmatrix. The linters keep running once in thelintjob.Why are the changes needed?
Currently, all matrix legs run the unit tests on the auto-provisioned JDK 27 toolchain, so Java 21, 25, and 26 are never tested. Also, every leg repeats the linters, which already run in the
lintjob.Does this PR introduce any user-facing change?
No. The default behavior is unchanged without the new property.
How was this patch tested?
Pass the CIs. I also verified locally that all unit tests pass on JDK 21, 25, and 26 with the new property.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 5.5