[SPARK-51551] [ML] [PYTHON] [CONNECT] For tuning algorithm, allow using save / load to replace cache #50324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Weichen Xu <[email protected]>
python/pyspark/ml/tuning.py
Outdated
| @@ -75,6 +76,15 @@ | |||
| ] | |||
|
|
|||
|
|
|||
| _SPARKML_TUNING_TEMP_DFS_PATH = "SPARKML_TUNING_TEMP_DFS_PATH" | |||
There was a problem hiding this comment.
what about a new parameter instead of this env variable?
There was a problem hiding this comment.
Spark config is not available in some circumstances. so I suggest to use environmental variable to config.
Signed-off-by: Weichen Xu <[email protected]>
Signed-off-by: Weichen Xu <[email protected]>
Signed-off-by: Weichen Xu <[email protected]>
Signed-off-by: Weichen Xu <[email protected]>
Signed-off-by: Weichen Xu <[email protected]>
zhengruifeng
approved these changes
Mar 21, 2025
python/pyspark/ml/tuning.py
Outdated
| validation = datasets[i][1] | ||
| train = datasets[i][0] | ||
|
|
||
| if tmp_dfs_path: |
There was a problem hiding this comment.
let's define a helper function:
def _cache(df):
if ...:
df.cache()
else:
spark = df._session
df.save
spark.read...
There was a problem hiding this comment.
then we need to handler the uncache step together in the helper function, i.e., it should be a context manager. is this you want ?
There was a problem hiding this comment.
context manager is a good idea
Signed-off-by: Weichen Xu <[email protected]>
Signed-off-by: Weichen Xu <[email protected]>
Signed-off-by: Weichen Xu <[email protected]>
zhengruifeng
approved these changes
Mar 24, 2025
Signed-off-by: Weichen Xu <[email protected]>
Signed-off-by: Weichen Xu <[email protected]>
|
merged to master. |
SauronShepherd
pushed a commit
to SauronShepherd/spark
that referenced
this pull request
Mar 25, 2025
…save / load to replace cache ### What changes were proposed in this pull request? For tuning algorithm, allow using save / load to replace cache. ### Why are the changes needed? Dataframe persisting is not well supported in certain cases, so we need a replacement. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manually. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#50324 from WeichenXu123/SPARK-51551. Authored-by: Weichen Xu <[email protected]> Signed-off-by: Weichen Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
For tuning algorithm, allow using save / load to replace cache.
Why are the changes needed?
Dataframe persisting is not well supported in certain cases, so we need a replacement.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually.
Was this patch authored or co-authored using generative AI tooling?
No.