[SPARK-48466][SQL][UI][FOLLOWUP] Handle nested empty relation in SparkPlanInfo #50350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuzqt
changed the title
cloud-fan
changed the title
|
thanks, merging to master/4.0! |
cloud-fan
pushed a commit
that referenced
this pull request
Mar 24, 2025
…kPlanInfo ### What changes were proposed in this pull request? Fix `SparkPlanInfo.fromLogicalPlan` to handle nested empty relation. Before: <img width="294" alt="Screenshot 2025-03-21 at 11 30 56 AM" src="https://github.com/user-attachments/assets/d03f6b88-13ad-4b67-bc4d-18b532e4dea2" /> After: <img width="390" alt="Screenshot 2025-03-20 at 5 51 21 PM" src="https://github.com/user-attachments/assets/0e4f775c-b9cf-4955-af17-5e47fa44e44b" /> ### Why are the changes needed? A followup for #46830, in the original PR I forget to handle nested empty relation. ### Does this PR introduce _any_ user-facing change? Yes, UI change ### How was this patch tested? Verifed in Spark UI ### Was this patch authored or co-authored using generative AI tooling? NO Closes #50350 from liuzqt/SPARK-48466. Authored-by: liuzqt <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit b8e0246) Signed-off-by: Wenchen Fan <[email protected]>
SauronShepherd
pushed a commit
to SauronShepherd/spark
that referenced
this pull request
Mar 25, 2025
…kPlanInfo ### What changes were proposed in this pull request? Fix `SparkPlanInfo.fromLogicalPlan` to handle nested empty relation. Before: <img width="294" alt="Screenshot 2025-03-21 at 11 30 56 AM" src="https://github.com/user-attachments/assets/d03f6b88-13ad-4b67-bc4d-18b532e4dea2" /> After: <img width="390" alt="Screenshot 2025-03-20 at 5 51 21 PM" src="https://github.com/user-attachments/assets/0e4f775c-b9cf-4955-af17-5e47fa44e44b" /> ### Why are the changes needed? A followup for apache#46830, in the original PR I forget to handle nested empty relation. ### Does this PR introduce _any_ user-facing change? Yes, UI change ### How was this patch tested? Verifed in Spark UI ### Was this patch authored or co-authored using generative AI tooling? NO Closes apache#50350 from liuzqt/SPARK-48466. Authored-by: liuzqt <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix
SparkPlanInfo.fromLogicalPlanto handle nested empty relation.Before:
After:
Why are the changes needed?
A followup for #46830, in the original PR I forget to handle nested empty relation.
Does this PR introduce any user-facing change?
Yes, UI change
How was this patch tested?
Verifed in Spark UI
Was this patch authored or co-authored using generative AI tooling?
NO