Skip to content

Conversation

@LuciferYang
Copy link
Contributor

What changes were proposed in this pull request?

This pr removes the override of the deprecated method SparkThrowable#getErrorClass from the Spark codebase. Since this method has been marked as deprecated and is defined as default String getErrorClass() { return getCondition(); }, the overriding behavior for it can be omitted based on the current code.

Why are the changes needed?

Code Cleanup

Does this PR introduce any user-facing change?

No, this only involves test code.

How was this patch tested?

Pass Github Actions

Was this patch authored or co-authored using generative AI tooling?

No

@LuciferYang LuciferYang changed the title [SPARK-54174][TESTS] Remove override of deprecated method SparkThrowable#getErrorClass in Spark code [SPARK-54174][CORE][CONNECT][TESTS] Remove override of deprecated method SparkThrowable#getErrorClass in Spark code Nov 4, 2025
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@dongjoon-hyun
Copy link
Member

Merged to master.

@LuciferYang
Copy link
Contributor Author

Thank you @dongjoon-hyun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants