[SPARK-56609][SQL][TESTS] Remove redundant SparkFunSuite mixin from QueryTest/PlanTest subclasses#55529
Open
zhengruifeng wants to merge 1 commit intoapache:masterfrom
Open
Conversation
…ueryTest/PlanTest subclasses Since `QueryTest` extends `SparkFunSuite with QueryTestBase with PlanTest`, and `PlanTest` extends `SparkFunSuite with PlanTestBase`, mixing `SparkFunSuite` in again alongside `QueryTest` or `PlanTest` is redundant. Cleanup across 7 test files: - `extends SparkFunSuite with QueryTest` -> `extends QueryTest` (3 files) - `extends SparkFunSuite with PlanTest` -> `extends PlanTest` (3 files) - `extends SparkFunSuite with SQLHelper with AdaptiveSparkPlanHelper with PlanTest` -> `extends PlanTest with SQLHelper with AdaptiveSparkPlanHelper` (1 file) Also removed the now-unused `SparkFunSuite` imports. Co-authored-by: Isaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Since
QueryTestextendsSparkFunSuite with QueryTestBase with PlanTest, andPlanTestextendsSparkFunSuite with PlanTestBase, mixingSparkFunSuitein again alongsideQueryTestorPlanTestin theextendslist is a no-op.Linearization:
Cleanup across 7 test files in
sql-catalyst,sql-core, andsql-hive:extends SparkFunSuite with QueryTest->extends QueryTest(3 files)MapStatusEndToEndSuiteExecutorSideSQLConfSuiteParquetCommitterSuite(also haswith LocalSparkContext, retained)extends SparkFunSuite with PlanTest->extends PlanTest(3 files)ConstraintPropagationSuiteExtractPredicatesWithinOutputSetSuiteFiltersSuiteextends SparkFunSuite with SQLHelper with AdaptiveSparkPlanHelper with PlanTest->extends PlanTest with SQLHelper with AdaptiveSparkPlanHelper(1 file)SparkSessionExtensionSuiteAlso removed the now-unused
SparkFunSuiteimports.Why are the changes needed?
Follow-up to SPARK-56591, which removed the analogous
QueryTest with SharedSparkSessionredundancy. Keeps theextendsclauses minimal and removes imports that no longer serve any purpose.Does this PR introduce any user-facing change?
No. Test-only change.
How was this patch tested?
dev/scalastylepasses. Existing tests in the affected suites exercise the unchanged test logic.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (model: claude-opus-4-7)