Skip to content

[SPARK-60139][PYTHON] Remove dead code UNSUPPORTED_COMBINATIONS #59343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bearomorphism wants to merge 2 commits into
base: master
Choose a base branch
from
+0 −10
Open

[SPARK-60139][PYTHON] Remove dead code UNSUPPORTED_COMBINATIONS #59343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed00a6f
[SPARK-60139][PYTHON] Annotate unsupported installation combinations
bearomorphism Oct 11, 2026
2c4be8a
[SPARK-60139][PYTHON] Remove unused unsupported combinations
bearomorphism Oct 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion python/pyspark/install.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
DEFAULT_HIVE = "hive2.3"
SUPPORTED_HADOOP_VERSIONS = ["hadoop3", "without-hadoop"]
SUPPORTED_HIVE_VERSIONS = ["hive2.3"]
UNSUPPORTED_COMBINATIONS = [] # type: ignore

# Official ASF-controlled hosts serving release checksums. Integrity metadata
# must come from these origins, never from a (community) mirror, so that a
Expand Down
9 changes: 0 additions & 9 deletions python/pyspark/tests/test_install_spark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
from pyspark.install import (
DEFAULT_HADOOP,
DEFAULT_HIVE,
UNSUPPORTED_COMBINATIONS,
_extract_tar,
_parse_sha512_checksum,
_verify_checksum,
Expand Down Expand Up @@ -190,14 +189,6 @@ def test_checked_versions(self):
)

# Negative test cases
for hadoop_version, hive_version in UNSUPPORTED_COMBINATIONS:
with self.assertRaisesRegex(RuntimeError, "Hive.*should.*Hadoop"):
checked_versions(
spark_version=test_version,
hadoop_version=hadoop_version,
hive_version=hive_version,
)

with self.assertRaisesRegex(RuntimeError, "Spark version should start with 'spark-'"):
checked_versions(
spark_version="malformed", hadoop_version=DEFAULT_HADOOP, hive_version=DEFAULT_HIVE
Expand Down