Skip to content

[SPARK-60144][PYTHON] Add type annotations to LooseVersion comparisons #59345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bearomorphism wants to merge 3 commits into
base: master
Choose a base branch
from
+14 −14
Open

[SPARK-60144][PYTHON] Add type annotations to LooseVersion comparisons #59345

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71c3806
[PYTHON] Add type annotations to LooseVersion comparisons
bearomorphism Oct 11, 2026
379e7a0
[PYTHON] Keep LooseVersion typing fix scoped to implementation
bearomorphism Oct 11, 2026
5968378
[SPARK-60144][PYTHON] Minimize LooseVersion annotation diff
bearomorphism Oct 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions python/pyspark/loose_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
# https://github.com/python/cpython/blob/3.11/Lib/distutils/version.py

import re
from typing import Optional
from types import NotImplementedType
from typing import Optional, Union


class LooseVersion:
Expand All @@ -31,37 +32,37 @@ def __str__(self) -> str:
def __repr__(self) -> str:
return "LooseVersion ('%s')" % str(self)

def __eq__(self, other): # type: ignore[no-untyped-def]
def __eq__(self, other: object) -> bool:
c = self._cmp(other)
if c is NotImplemented:
return c
return NotImplemented
return c == 0

def __lt__(self, other): # type: ignore[no-untyped-def]
def __lt__(self, other: Union["LooseVersion", str]) -> bool:
c = self._cmp(other)
if c is NotImplemented:
return c
return NotImplemented
return c < 0

def __le__(self, other): # type: ignore[no-untyped-def]
def __le__(self, other: Union["LooseVersion", str]) -> bool:
c = self._cmp(other)
if c is NotImplemented:
return c
return NotImplemented
return c <= 0

def __gt__(self, other): # type: ignore[no-untyped-def]
def __gt__(self, other: Union["LooseVersion", str]) -> bool:
c = self._cmp(other)
if c is NotImplemented:
return c
return NotImplemented
return c > 0

def __ge__(self, other): # type: ignore[no-untyped-def]
def __ge__(self, other: Union["LooseVersion", str]) -> bool:
c = self._cmp(other)
if c is NotImplemented:
return c
return NotImplemented
return c >= 0

def _cmp(self, other): # type: ignore[no-untyped-def]
def _cmp(self, other: object) -> Union[int, NotImplementedType]:
if isinstance(other, str):
other = LooseVersion(other)
elif not isinstance(other, LooseVersion):
Expand All @@ -71,5 +72,4 @@ def _cmp(self, other): # type: ignore[no-untyped-def]
return 0
if self.version < other.version:
return -1
if self.version > other.version:
return 1
return 1