Repository navigation
[WIP][SQL] Return zero for instr with zero start and empty substring - #59346
Draft
zhangxinyao88 wants to merge 1 commit into
Draft
zhangxinyao88 wants to merge 1 commit into
zhangxinyao88 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Check
start = 0before handling an empty search pattern in the binary, lowercase, and ICU implementations ofinstr.Why are the changes needed?
The documented behavior of
instris to return zero when the start position is zero. The empty-pattern handling currently runs first and returns 1 instead.Does this PR introduce any user-facing change?
Yes. Before this fix,
instr('abc', '', 0, 1)returns1. After this fix, it returns0, matching the documented behavior.How was this patch tested?
Added regression tests covering four collation groups, empty and nonempty input, ASCII and Unicode input, and multiple occurrences, including interpreted and generated SQL execution.
The regressions failed before the fix. After the fix, all 58 focused Java tests and all 74
StringExpressionsSuitetests passed, and the Maven reactor succeeded.Commit:
6b95d5517b9f4dc0f1d69a790aa3abef39b71c47.Was this patch authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex (GPT-6)