Repository navigation
[SPARK-60145][PYTHON] Remove type: ignore[var-annotated] in pyspark.sql - #59347
Closed
soaring0616 wants to merge 1 commit into
Closed
soaring0616 wants to merge 1 commit into
soaring0616 wants to merge 1 commit into
Conversation
Replace `type: ignore[var-annotated]` on `PySparkPlotAccessor._backends` with an explicit `dict[str, ModuleType]` annotation. mypy cannot infer the type of an empty dict literal, so the suppression hid the real type. The value type matches the return type of `_get_plot_backend`. No. - `dev/lint-python --ruff` passes. - `dev/lint-python --mypy`: no errors in `python/pyspark/sql/plot/core.py`. There are 3 remaining `"FieldDescriptor" has no attribute "label"` errors in `python/pyspark/sql/connect/client/core.py` also occur on an unmodified master in my environment, so they are unrelated to this change. - `python/run-tests --testnames pyspark.sql.tests.plot.test_frame_plot` passes. Generated by Claude-code (Sonnet 5.5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Replace
type: ignore[var-annotated]onPySparkPlotAccessor._backendswith an explicitdict[str, ModuleType]annotation.Why are the changes needed?
mypy cannot infer the type of an empty dict literal, so the suppression hid the real type. The value type matches the return type of
_get_plot_backend.Does this PR introduce any user-facing change?
No
How was this patch tested?
dev/lint-python --ruffpasses.dev/lint-python --mypy: no errors inpython/pyspark/sql/plot/core.py. There are 3 remaining"FieldDescriptor" has no attribute "label"errors inpython/pyspark/sql/connect/client/core.pyalso occur on an unmodified master in my environment, so they are unrelated to this change.python/run-tests --testnames pyspark.sql.tests.plot.test_frame_plotpasses.Was this patch authored or co-authored using generative AI tooling?
Generated by Claude-code (Sonnet 5.5)