Skip to content

Commit fa95171

Browse files
committed
WW-5533 Add compilation support for Jakarta EE 11
1 parent d2cb444 commit fa95171

File tree

6 files changed

+22
-9
lines changed

6 files changed

+22
-9
lines changed

.github/workflows/maven.yml

+12-5
Original file line numberDiff line numberDiff line change
@@ -30,18 +30,25 @@ env:
3030

3131
jobs:
3232
build:
33-
name: Build and Test
33+
name: Build and Test (JDK ${{ matrix.java }})${{ matrix.profile == '-Pjakartaee11' && ' with Jakarta EE 11' || matrix.profile }}
3434
runs-on: ubuntu-latest
3535
strategy:
3636
matrix:
37-
java: [ '17', '21' ]
37+
include:
38+
- java: '17'
39+
profile: ''
40+
- java: '21'
41+
profile: ''
42+
- java: '21'
43+
profile: '-Pjakartaee11'
3844
steps:
3945
- name: Checkout code
4046
uses: actions/checkout@v4
41-
- uses: actions/setup-java@v4
47+
- name: Setup Java ${{ matrix.java }}
48+
uses: actions/setup-java@v4
4249
with:
4350
distribution: temurin
4451
java-version: ${{ matrix.java }}
4552
cache: 'maven'
46-
- name: Build with Maven on Java ${{ matrix.java }}
47-
run: mvn -B -V -DskipAssembly verify --no-transfer-progress
53+
- name: Maven Verify on Java ${{ matrix.java }}${{ matrix.profile == '-Pjakartaee11' && ' (Jakarta EE 11)' || matrix.profile }}
54+
run: mvn -B -V -DskipAssembly verify ${{ matrix.profile }} --no-transfer-progress

core/src/test/java/org/apache/struts2/dispatcher/multipart/AbstractMultiPartRequestTest.java

-1
Original file line numberDiff line numberDiff line change
@@ -417,7 +417,6 @@ public void mismatchCharset() throws IOException {
417417
assertThat(JakartaServletDiskFileUpload.isMultipartContent(mockRequest)).isTrue();
418418

419419
// when
420-
mockRequest.setCharacterEncoding(null);
421420
multiPart.setDefaultEncoding(StandardCharsets.ISO_8859_1.name());
422421
multiPart.parse(mockRequest, tempDir);
423422

plugins/tiles/src/main/java/org/apache/tiles/el/ScopeELResolver.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ public Class<?> getCommonPropertyType(ELContext context, Object base) {
5757
/**
5858
* {@inheritDoc}
5959
*/
60-
@Override
60+
// @Override // To allow compilation with Maven profile jakartaee11 where this interface method does not exist
6161
public Iterator<FeatureDescriptor> getFeatureDescriptors(ELContext context, Object base) {
6262
if (base != null) {
6363
return Collections.emptyIterator();

plugins/tiles/src/main/java/org/apache/tiles/el/TilesContextBeanELResolver.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ public Class<?> getCommonPropertyType(ELContext context, Object base) {
4747
}
4848

4949
/** {@inheritDoc} */
50-
@Override
50+
// @Override // To allow compilation with Maven profile jakartaee11 where this interface method does not exist
5151
public Iterator<FeatureDescriptor> getFeatureDescriptors(ELContext context, Object base) {
5252
List<FeatureDescriptor> list = new ArrayList<>();
5353

plugins/tiles/src/main/java/org/apache/tiles/el/TilesContextELResolver.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ public Class<?> getCommonPropertyType(ELContext context, Object base) {
7070
/**
7171
* {@inheritDoc}
7272
*/
73-
@Override
73+
// @Override // To allow compilation with Maven profile jakartaee11 where this interface method does not exist
7474
public Iterator<FeatureDescriptor> getFeatureDescriptors(ELContext context,
7575
Object base) {
7676
// only resolve at the root of the context

pom.xml

+7
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,13 @@
150150
<module>assembly</module>
151151
</modules>
152152
</profile>
153+
<profile>
154+
<id>jakartaee11</id>
155+
<properties>
156+
<jakarta-ee.version>11.0.0-M5</jakarta-ee.version>
157+
<spring.version>7.0.0-M2</spring.version>
158+
</properties>
159+
</profile>
153160
<profile>
154161
<id>dependency-check</id>
155162
<build>

0 commit comments

Comments
 (0)