WW-5512 Extends the container to support injecting optional parameters into constructor

[lukaszlenart]

WW-5512

[sonarqubecloud]

Quality Gate failed

Failed conditions
22 Security Hotspots
42.2% Coverage on New Code (required ≥ 80%)
3.4% Duplication on New Code (required ≤ 3%)
E Security Rating on New Code (required ≥ A)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[kusalk]

Does this also work for constructors with multiple optional parameters where 1 is available and the other is not?

[lukaszlenart]

This is strictly for missing all the parameters and no default constructor exists.

[kusalk]

How about the following - both parameters are injected as null even though one exists. Is that expected? I guess my concern here is that unintuitive behaviour here could lead to bugs being introduced in the future

@Inject(required = false)
public ConstructorCheck(@Inject(value = "constructorCheck.name") String name, @Inject(value = "nonExistingConstant") String name2) {

[lukaszlenart]

I can add a test case for that, but that should block such a situation

(constructor.getParameterCount() > 0 && parameterInjectors == null)

constructor has parameters defined but there is nothing to inject.

[kusalk]

Yep if you can add a test that verifies the behaviour for my given example hasn't changed (injection exception is thrown) that would make me more comfortable