Skip to content

fix: %s for plural (Added to %s dashboard) to avoid poedit alert #32881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xavier-GitHub76
Copy link
Contributor

@xavier-GitHub76 xavier-GitHub76 commented Mar 27, 2025

This PR fix #32674

SUMMARY

Update to avoid alert in poedit, the msgid use %s for singular and plural.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before :
image

After :
image

TESTING INSTRUCTIONS

Create a graph and add it to a dashboard
The tag mention : "Added to 1 dashboard"
image

@github-actions github-actions bot added i18n Namespace | Anything related to localization i18n:spanish Translation related to Spanish language i18n:italian Translation related to Italian language i18n:french Translation related to French language i18n:chinese Translation related to Chinese language i18n:japanese Translation related to Japanese language i18n:russian Translation related to Russian language i18n:korean Translation related to Korean language i18n:dutch i18n:slovak i18n:ukrainian i18n:portuguese i18n:brazilian i18n:traditional-chinese labels Mar 27, 2025
@dosubot dosubot bot added the i18n:general Related to translations label Mar 27, 2025
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Files scanned
File Path Reviewed
superset-frontend/src/explore/components/ExploreChartHeader/useExploreMetadataBar.tsx

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

  • You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
  • You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
  • Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
  • On any given comment that Korbit raises on your pull request, you can have a discussion with Korbit by replying to the comment.
  • Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

  • Check out our docs on how you can make Korbit work best for you and your team.
  • Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings
Setting Value
Review Schedule Automatic excluding drafts
Max Issue Count 10
Automatic PR Descriptions
Issue Categories
Category Enabled
Documentation
Logging
Error Handling
Readability
Design
Performance
Security
Functionality

Feedback and Support

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

Copy link

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.41%. Comparing base (76d897e) to head (248b9f8).
Report is 1688 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #32881       +/-   ##
===========================================
+ Coverage   60.48%   83.41%   +22.92%     
===========================================
  Files        1931      549     -1382     
  Lines       76236    39486    -36750     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    32938    -13176     
+ Misses      28017     6548    -21469     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 48.39% <ø> (-0.76%) ⬇️
javascript ?
mysql 75.63% <ø> (?)
postgres 75.70% <ø> (?)
presto 52.88% <ø> (-0.92%) ⬇️
python 83.41% <ø> (+19.91%) ⬆️
sqlite 75.20% <ø> (?)
unit 61.39% <ø> (+3.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@justinpark justinpark requested review from rusackas and villebro March 27, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n:brazilian i18n:chinese Translation related to Chinese language i18n:dutch i18n:french Translation related to French language i18n:general Related to translations i18n:italian Translation related to Italian language i18n:japanese Translation related to Japanese language i18n:korean Translation related to Korean language i18n:portuguese i18n:russian Translation related to Russian language i18n:slovak i18n:spanish Translation related to Spanish language i18n:traditional-chinese i18n:ukrainian i18n Namespace | Anything related to localization size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Messages.pot / Added to 1 dashboard
2 participants