feat(dashboard): "embed code" option on dashboard share tab #33163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Unnecessary Event Optional Chaining ▹ view | ✅ Fix detected |
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/src/dashboard/components/menu/ShareMenuItems/index.tsx | ✅ |
| superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
| @@ -109,6 +118,27 @@ const ShareMenuItems = (props: ShareMenuItemProps) => { | |||
| <Menu.Item key={MenuKeys.ShareByEmail} onClick={() => onShareByEmail()}> | |||
| {emailMenuItemTitle} | |||
| </Menu.Item> | |||
| {sliceExists && ( | |||
| <Menu.Item key="embed_code"> | |||
| <div onClick={e => e?.stopPropagation()} role="button" tabIndex={0}> | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
justinpark
added
the
review:checkpoint
rusackas
reviewed
Apr 17, 2025
rusackas
reviewed
Apr 17, 2025
superset-frontend/src/dashboard/components/menu/ShareMenuItems/index.tsx
Outdated
Show resolved
Hide resolved
michael-s-molina
removed
the
review:checkpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This change adds an "Embed code" option to the chart sharing menu in Superset. Users can now easily get the iframe code to embed individual charts in other websites.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Open a dashboard, click on the three dot icon, and verify that the option "Embed Code" shows up on the Share tab. This option should bring the Embed code modal.
ADDITIONAL INFORMATION