fix: Temporal filter conversion in viz migrations

[michael-s-molina]

SUMMARY

This PR fixes a bug with the conversion of legacy temporal columns to filters that happens during viz migrations. The problem occurred when generating the filter SQL expression from a custom SQL column. Previously, the SQL expression was missing the time ranges resulting in invalid WHERE clauses.

TESTING INSTRUCTIONS

Create a legacy chart with a temporal column that uses custom SQL and use the CLI to migrate the viz.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[korbit-ai]

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Category	Issue	Status
	Exclusive End Date Boundary ▹ view	🧠 Incorrect

Files scanned

​

File Path	Reviewed
superset/migrations/shared/migrate_viz/base.py	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

[codecov]

Codecov Report

Attention: Patch coverage is 72.22222% with 5 lines in your changes missing coverage. Please review.

Project coverage is 83.24%. Comparing base (26ff734) to head (3c9e0bb).
Report is 20 commits behind head on master.

Files with missing lines	Patch %	Lines
superset/migrations/shared/migrate_viz/base.py	72.22%	5 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #33224       +/-   ##
===========================================
+ Coverage        0   83.24%   +83.24%     
===========================================
  Files           0      553      +553     
  Lines           0    39936    +39936     
===========================================
+ Hits            0    33245    +33245     
- Misses          0     6691     +6691     

Flag	Coverage Δ
hive	48.27% <5.55%> (?)
mysql	75.44% <22.22%> (?)
postgres	75.52% <22.22%> (?)
presto	52.75% <5.55%> (?)
python	83.24% <72.22%> (?)
sqlite	75.01% <22.22%> (?)
unit	61.32% <72.22%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.