Skip to content

fix(docs): document APP_ICON deprecation in favor of theme-based brandLogoUrl#35298

Open
sadpandajoe wants to merge 1 commit intomasterfrom
fix-app-root-icons-docs
Open

fix(docs): document APP_ICON deprecation in favor of theme-based brandLogoUrl#35298
sadpandajoe wants to merge 1 commit intomasterfrom
fix-app-root-icons-docs

Conversation

@sadpandajoe
Copy link
Member

@sadpandajoe sadpandajoe commented Sep 25, 2025 •
edited
Loading

SUMMARY

Documented the deprecation of APP_ICON configuration variable in favor of the new theme-based logo system introduced in PR #31590. This breaking change was causing confusion for users upgrading to Superset 6.0.0rc1 who found their custom logos no longer working.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: Fixes "APP_ICON" is not displayed #34824
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

korbit-ai[bot]
korbit-ai bot reviewed Sep 25, 2025
View reviewed changes
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

@dosubot dosubot bot added the doc Namespace | Anything related to documentation label Sep 25, 2025
mistercrunch
mistercrunch reviewed Sep 26, 2025
View reviewed changes
Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh seems APP_ICON still referenced in superset/config.py, probably want to wipe that config too.

@sadpandajoe
Copy link
Member Author

sadpandajoe commented Sep 26, 2025

Oh seems APP_ICON still referenced in superset/config.py, probably want to wipe that config too.

Ok I can do it as part of this PR too and just change the UPDATING to that.

@scottyeung
Copy link

scottyeung commented Sep 26, 2025

A side note here, brandLogoUrl in superset-frontend/packages/superset-ui-core/src/theme/Theme.tsx doesn't include SUPERSET_APP_ROOT. It's working after I hardcoded the subpath

@ahirner
Copy link

ahirner commented Dec 30, 2025

seems APP_ICON still referenced in superset/config.py

Also in superset/app.py and superset/views/base.py. It's not clear how to proceed for logos with absolute URLs. Maybe that also needs #36058.

mistercrunch
mistercrunch approved these changes Feb 10, 2026
View reviewed changes
Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rusackas
rusackas approved these changes Feb 12, 2026
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sadpandajoe @claude @rusackas
docs: document APP_ICON deprecation in favor of theme-based brandLogoUrl
d6d1f35 
The APP_ICON configuration variable was deprecated in PR #31590 (Ant Design v5 theming overhaul) but this breaking change was not documented in UPDATING.md. Users were confused when their custom logos stopped working in Superset 6.0.0rc1.

Added clear migration instructions showing how to replace APP_ICON with the new THEME_DEFAULT.token.brandLogoUrl configuration.

Resolves misconceptions about APP_ICON functionality mentioned in issue #34824.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@rusackas rusackas force-pushed the fix-app-root-icons-docs branch from b8ccd1f to d6d1f35 Compare February 12, 2026 22:04
@github-actions github-actions bot removed the doc Namespace | Anything related to documentation label Feb 12, 2026
@rusackas
Copy link
Member

rusackas commented Feb 12, 2026

rebased it for ya :D

@codeant-ai-for-open-source
Copy link
Contributor

codeant-ai-for-open-source bot commented Feb 12, 2026

Sequence Diagram

This PR updates UPDATING.md to document that the legacy APP_ICON config is deprecated and the frontend now uses THEME_DEFAULT.token.brandLogoUrl for custom logos. The diagram shows the upgrade/migration success path and how the frontend resolves the logo.

sequenceDiagram
    participant Admin
    participant superset_config as "superset_config.py"
    participant Frontend

    Admin->>superset_config: Previously set APP_ICON = "/static/.../logo.png"
    note right of superset_config: After PR 31590 APP_ICON is ignored
    Admin->>superset_config: Replace with THEME_DEFAULT.token.brandLogoUrl
    superset_config->>Frontend: Expose THEME_DEFAULT.token.brandLogoUrl
    Frontend-->>Admin: Render custom logo from brandLogoUrl
Loading

Generated by CodeAnt AI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mistercrunch mistercrunch mistercrunch approved these changes

@rusackas rusackas rusackas approved these changes

+1 more reviewer

@korbit-ai korbit-ai[bot] korbit-ai[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"APP_ICON" is not displayed

5 participants

@sadpandajoe @scottyeung @ahirner @rusackas @mistercrunch

Comments