test(frontend): remove 3 duplicate JSX test files #35590
+289
−577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Merged ListView.test.jsx comprehensive tests into ListView.test.tsx (9 tests total) - Removed DatasourceControl.test.jsx (all tests already in .tsx with 21 tests) - Removed VizTypeControl.test.jsx (all tests already in .tsx with 10 tests) All 40 tests pass. TypeScript migration aligns with frontend modernization goals. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
- Added MockedListViewProps type for proper Jest mock typing - Replaced string literal operators with ListViewFilterOperator enum values - Fixed fetchSelectsMock to return proper Promise structure - Properly typed fetchData mock with jest.fn<> generic parameters - Changed bulk action 'style' property to 'type' (correct interface) - Removed 'title' property (not in ListViewProps interface) - Created factory function with explicit overrides pattern All 9 ListView tests pass with full TypeScript type safety. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Removes 3 duplicate JSX test files that have TypeScript counterparts already in the codebase. This cleanup aligns with the frontend modernization effort to eliminate JavaScript files.
Files removed:
Impact:
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Verify all migrated tests pass:
npm run test -- src/components/ListView/ListView.test.tsx
npm run test -- src/explore/components/controls/DatasourceControl/DatasourceControl.test.tsx
npm run test -- src/explore/components/controls/VizTypeControl/VizTypeControl.test.tsx
ADDITIONAL INFORMATION