Skip to content

Conversation

dpgaspar
Copy link
Member

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

korbit-ai bot commented Oct 13, 2025

Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment /korbit-review.

Your admin can change your review schedule in the Korbit Console

Copy link
Contributor

Bito Automatic Review Skipped - Draft PR

Bito didn't auto-review because this pull request is in draft status.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change draft PR review settings here, or contact your Bito workspace admin at [email protected].

return hashlib.sha256(val.encode("utf-8")).hexdigest()
elif algorithm == "md5":
# MD5 is only acceptable for legacy compatibility
return hashlib.md5(val.encode("utf-8")).hexdigest() # noqa: S324

Check failure

Code scanning / CodeQL

Use of a broken or weak cryptographic hashing algorithm on sensitive data High

Sensitive data (certificate)
is used in a hashing algorithm (MD5) that is insecure.
Sensitive data (certificate)
is used in a hashing algorithm (MD5) that is insecure.
Sensitive data (certificate)
is used in a hashing algorithm (MD5) that is insecure.
Sensitive data (certificate)
is used in a hashing algorithm (MD5) that is insecure.
Sensitive data (certificate)
is used in a hashing algorithm (MD5) that is insecure.
Sensitive data (certificate)
is used in a hashing algorithm (MD5) that is insecure.
Sensitive data (certificate)
is used in a hashing algorithm (MD5) that is insecure.
Sensitive data (id)
is used in a hashing algorithm (MD5) that is insecure.
Sensitive data (id)
is used in a hashing algorithm (MD5) that is insecure.
Sensitive data (id)
is used in a hashing algorithm (MD5) that is insecure.
Sensitive data (id)
is used in a hashing algorithm (MD5) that is insecure.
Sensitive data (id)
is used in a hashing algorithm (MD5) that is insecure.
Sensitive data (id)
is used in a hashing algorithm (MD5) that is insecure.
Sensitive data (id)
is used in a hashing algorithm (MD5) that is insecure.
Sensitive data (id)
is used in a hashing algorithm (MD5) that is insecure.
Sensitive data (id)
is used in a hashing algorithm (MD5) that is insecure.
Sensitive data (id)
is used in a hashing algorithm (MD5) that is insecure.
Sensitive data (certificate)
is used in a hashing algorithm (MD5) that is insecure.
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

❌ Patch coverage is 75.67568% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.85%. Comparing base (76d897e) to head (7debb41).
⚠️ Report is 2707 commits behind head on master.

Files with missing lines Patch % Lines
superset/key_value/utils.py 61.53% 3 Missing and 2 partials ⚠️
superset/utils/hashing.py 86.36% 1 Missing and 2 partials ⚠️
superset/extensions/metastore_cache.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #35621       +/-   ##
===========================================
+ Coverage   60.48%   71.85%   +11.37%     
===========================================
  Files        1931      589     -1342     
  Lines       76236    43634    -32602     
  Branches     8568     4724     -3844     
===========================================
- Hits        46114    31355    -14759     
+ Misses      28017    11036    -16981     
+ Partials     2105     1243      -862     
Flag Coverage Δ
hive 46.27% <54.05%> (-2.89%) ⬇️
javascript ?
mysql 70.89% <75.67%> (?)
postgres 70.94% <75.67%> (?)
presto 49.98% <67.56%> (-3.83%) ⬇️
python 71.82% <75.67%> (+8.31%) ⬆️
sqlite 70.54% <75.67%> (?)
unit 100.00% <ø> (+42.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant