-
Notifications
You must be signed in to change notification settings - Fork 16k
feat: add option for hash algorithms #35621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: add option for hash algorithms #35621
Conversation
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment
|
Bito Automatic Review Skipped - Draft PR |
return hashlib.sha256(val.encode("utf-8")).hexdigest() | ||
elif algorithm == "md5": | ||
# MD5 is only acceptable for legacy compatibility | ||
return hashlib.md5(val.encode("utf-8")).hexdigest() # noqa: S324 |
Check failure
Code scanning / CodeQL
Use of a broken or weak cryptographic hashing algorithm on sensitive data High
Sensitive data (certificate)
Sensitive data (certificate)
Sensitive data (certificate)
Sensitive data (certificate)
Sensitive data (certificate)
Sensitive data (certificate)
Sensitive data (certificate)
Sensitive data (id)
Sensitive data (id)
Sensitive data (id)
Sensitive data (id)
Sensitive data (id)
Sensitive data (id)
Sensitive data (id)
Sensitive data (id)
Sensitive data (id)
Sensitive data (id)
Sensitive data (certificate)
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #35621 +/- ##
===========================================
+ Coverage 60.48% 71.85% +11.37%
===========================================
Files 1931 589 -1342
Lines 76236 43634 -32602
Branches 8568 4724 -3844
===========================================
- Hits 46114 31355 -14759
+ Misses 28017 11036 -16981
+ Partials 2105 1243 -862
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION