Skip to content

Conversation

@SBIN2010
Copy link
Contributor

@SBIN2010 SBIN2010 commented Nov 2, 2025

SUMMARY

This PR fix #35819

After deleting the dashboard, getData was added.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

SBIN2010 and others added 30 commits October 22, 2024 23:07
@dosubot dosubot bot added the listview:dashboards Related to the Dashboards' list label Nov 2, 2025
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Files scanned
File Path Reviewed
superset-frontend/src/views/CRUD/utils.tsx

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

Copy link
Contributor

@bito-code-review bito-code-review bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Agent Run #67bcca

Actionable Suggestions - 2
  • superset-frontend/src/views/CRUD/utils.tsx - 2
    • Incorrect refresh filter handling in chart delete · Line 340-340
    • Incorrect refresh filter handling in dashboard delete · Line 340-340
Review Details
  • Files reviewed - 1 · Commit Range: 19151d1..fb5a89e
    • superset-frontend/src/views/CRUD/utils.tsx
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by Bito Logo

@SBIN2010 SBIN2010 requested review from msyavuz and rusackas November 2, 2025 22:05
@pull-request-size pull-request-size bot added size/XS and removed size/M labels Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

listview:dashboards Related to the Dashboards' list size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete dashboard in main page doesnt reload interface

1 participant