- 
                Notifications
    
You must be signed in to change notification settings  - Fork 16.1k
 
fix: removed dashboard from main page in "All" tab, refreshes dashboard list #35945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This reverts commit 35aaeb6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've completed my review and didn't find any issues.
Files scanned
| File Path | Reviewed | 
|---|---|
| superset-frontend/src/views/CRUD/utils.tsx | ✅ | 
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review Agent Run #67bcca
Actionable Suggestions - 2
- 
superset-frontend/src/views/CRUD/utils.tsx - 2
- Incorrect refresh filter handling in chart delete · Line 340-340
 - Incorrect refresh filter handling in dashboard delete · Line 340-340
 
 
Review Details
- 
Files reviewed - 1 · Commit Range:
19151d1..fb5a89e- superset-frontend/src/views/CRUD/utils.tsx
 
 - 
Files skipped - 0
 - 
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
 - Detect-secrets (Secret Scanner) - ✔︎ Successful
 
 
Bito Usage Guide
Commands
Type the following command in the pull request comment and save the comment.
- 
/review- Manually triggers a full AI review. - 
/pause- Pauses automatic reviews on this pull request. - 
/resume- Resumes automatic reviews. - 
/resolve- Marks all Bito-posted review comments as resolved. - 
/abort- Cancels all in-progress reviews. 
Refer to the documentation for additional commands.
Configuration
This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at [email protected].
Documentation & Help
SUMMARY
This PR fix #35819
After deleting the dashboard, getData was added.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION