[SYSTEMDS-3740] Python API Builtin countDistinct #2087
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baunsgaard
reviewed
Sep 3, 2024
| elif axis is None: | ||
| return Scalar(self.sds_context, 'countDistinct', [self]) | ||
| raise ValueError( | ||
| f"Axis has to be either 0, 1 or None, for column, row or complete {self.operation}") |
There was a problem hiding this comment.
This PR is missing a test case for the error.
There was a problem hiding this comment.
@Baunsgaard added, I also removed the print statements and squashed + rebased
There was a problem hiding this comment.
@Baunsgaard the older test cases for the aggregation like min, max and co, it makes sense to add test cases there as well - or are there some in place which I havent found?
There was a problem hiding this comment.
then we need to add it for them as well,
unfortunately we do not see these things because we do not have code coverage for the Python API,
It would be cool to have that as well.
e-strauss
force-pushed
the
MISSING_BUILTIN_COUNT_DISTINCT
branch
from
73f4b29 to
2f63100
Compare
|
LGTM, merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[SYSTEMDS-3740] Python API Builtin countDistinct
This patch adds the builtin operator for countDistinct to the python api.