[SYSTEMDS-3741] Python API Builtin countDistinctApprox #2088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baunsgaard
reviewed
Sep 3, 2024
| elif axis is None: | ||
| return Scalar(self.sds_context, 'countDistinctApprox', [self]) | ||
| raise ValueError( | ||
| f"Axis has to be either 0, 1 or None, for column, row or complete {self.operation}") |
There was a problem hiding this comment.
similarly here, we are missing a test case for the error.
e-strauss
force-pushed
the
MISSING_BUILTIN_COUNT_DISTINCT_APPROX
branch
from
39fae8d to
052ffc1
Compare
|
LGTM, and Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[SYSTEMDS-3741] Python API Builtin countDistinctApprox
This patch adds the builtin operator for countDistinctApprox to the python api.