Skip to content

Conversation

e-strauss
Copy link
Contributor

[SYSTEMDS-3751, SYSTEMDS-3752, SYSTEMDS-3753] Python API missing buitin isNA, isNaN, isInf

This patch adds the built in operator for isNA, isNaN, isInf to the python api.

@Baunsgaard
Copy link
Contributor

is this operation only valid for matrices, if that is the case, we need to fix it in the system in general.
If not, we need to add it to the scalar node as well.

@e-strauss
Copy link
Contributor Author

e-strauss commented Sep 3, 2024

is this operation only valid for matrices, if that is the case, we need to fix it in the system in general. If not, we need to add it to the scalar node as well.

I will check that

@e-strauss e-strauss force-pushed the MISSING_BUILTIN_ISNA2 branch from f6c57ce to b52c074 Compare September 3, 2024 12:48
@e-strauss
Copy link
Contributor Author

updated for scalar as well

@Baunsgaard Baunsgaard closed this in 49d00d2 Sep 3, 2024
@Baunsgaard
Copy link
Contributor

LGTM, merged, while merging i formatted the test, it is only minor things.
I can suggest that you adhere to the 'black' formatted code, since this is the auto formatter that I 'unofficially' use for the code in the Python API.

@e-strauss e-strauss deleted the MISSING_BUILTIN_ISNA2 branch September 4, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants