[SYSTEMDS-3744, SYSTEMDS-3745, SYSTEMDS-3746, SYSTEMDS-3747, SYSTEMDS-3748] Python API Builtin cumsum, cumprod, summin, cummax, cumsumprod #2093
Conversation
e-strauss
force-pushed
the
MISSING_BUILTIN_CUMSUM
branch
from
65b8d15 to
6032c72
Compare
| return Matrix(self.sds_context, "replace", named_input_nodes={"target": self, "pattern": pattern, "replacement": replacement}) | ||
|
|
||
| def cumsum(self) -> 'Matrix': | ||
| """ Column prefix-sum. (For row-prefix sum, use X.t().cumsum().t()) |
There was a problem hiding this comment.
interesting, do we not support cumulative sum on rows?
There was a problem hiding this comment.
jep, afaik. It says so in the docu (even Arnab told me yesterday not trust it ^^) and java code suggests it too
There was a problem hiding this comment.
I think we should probably make a task for this, if it really is not supported.
It seems odd to to two transposes to do row cumulative operations.
There was a problem hiding this comment.
well, it's fine to add a task even through the focus was always R compliance and R defines it as column-wise cumulative aggregates (unary operation without additional parameters). The same also applies to rev(). Recently some of the operations like roll() are more inspired by numpy and there you have indeed usually axis parameters.
There was a problem hiding this comment.
Also when committing this task here lets call it [SYSTEMDS-3744-48] ... and in the future let's create JIRA tasks for groups of operations that belong together. Thanks.
There was a problem hiding this comment.
i have made a task for it and marked it as a student project, unrelated to this PR, such that we do not forget it.
https://issues.apache.org/jira/browse/SYSTEMDS-3762
e-strauss
changed the title
e-strauss
force-pushed
the
MISSING_BUILTIN_CUMSUM
branch
3 times, most recently
from
da4f3fa to
d69ef96
Compare
|
the PR should be ready now, I just changed the description of the cumsumprod operator |
e-strauss
changed the title
…-3748] Python API Builtin cumsum, cumprod, cumsumprod, cummin, cummax
e-strauss
force-pushed
the
MISSING_BUILTIN_CUMSUM
branch
from
d69ef96 to
febadb9
Compare
|
reformatted |
3 participants
[SYSTEMDS-3744, SYSTEMDS-3745, SYSTEMDS-3746, SYSTEMDS-3747, SYSTEMDS-3748] Python API Builtin cumsum, cumprod, summin, cummax, cumsumprod
This patch adds the builtin operators cumsum, cumprod, summin, cummax, cumsumprod to the python api.