-
Notifications
You must be signed in to change notification settings - Fork 500
Sparse row templates #2276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sparse row templates #2276
Conversation
There seem to be still some codegen errors - do you need any help @Frxms ? |
As far as i understood it, the Unary class was missing its ROW_VARS case. Could you run the tests again please? @mboehm7 |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2276 +/- ##
============================================
- Coverage 72.94% 72.56% -0.39%
- Complexity 46070 46260 +190
============================================
Files 1479 1489 +10
Lines 172616 174458 +1842
Branches 33783 34266 +483
============================================
+ Hits 125922 126598 +676
- Misses 37202 38266 +1064
- Partials 9492 9594 +102 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I have implemented SparseRowVectors into the Binary and Unary templates. I have also added an "S" to every result variable that is sparse to keep track of sparse intermediates.