Skip to content

Conversation

Frxms
Copy link
Contributor

@Frxms Frxms commented Jun 23, 2025

I have implemented SparseRowVectors into the Binary and Unary templates. I have also added an "S" to every result variable that is sparse to keep track of sparse intermediates.

@mboehm7
Copy link
Contributor

mboehm7 commented Jul 20, 2025

There seem to be still some codegen errors - do you need any help @Frxms ?

@Frxms
Copy link
Contributor Author

Frxms commented Jul 20, 2025

As far as i understood it, the Unary class was missing its ROW_VARS case. Could you run the tests again please? @mboehm7

Copy link

codecov bot commented Jul 26, 2025

Codecov Report

❌ Patch coverage is 41.44737% with 89 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.56%. Comparing base (38b73ae) to head (87dcaee).
⚠️ Report is 41 commits behind head on main.

Files with missing lines Patch % Lines
...g/apache/sysds/hops/codegen/cplan/CNodeBinary.java 39.47% 42 Missing and 4 partials ⚠️
...g/apache/sysds/hops/codegen/cplan/java/Binary.java 38.70% 13 Missing and 6 partials ⚠️
...ava/org/apache/sysds/hops/codegen/cplan/CNode.java 30.00% 4 Missing and 3 partials ⚠️
...rg/apache/sysds/hops/codegen/cplan/CNodeUnary.java 33.33% 3 Missing and 3 partials ⚠️
.../apache/sysds/hops/codegen/cplan/CNodeTernary.java 20.00% 0 Missing and 4 partials ⚠️
...org/apache/sysds/hops/codegen/cplan/CNodeNary.java 33.33% 1 Missing and 1 partial ⚠️
.../org/apache/sysds/hops/codegen/cplan/CNodeRow.java 0.00% 0 Missing and 2 partials ⚠️
...rg/apache/sysds/hops/codegen/cplan/java/Unary.java 60.00% 1 Missing and 1 partial ⚠️
src/main/java/org/apache/sysds/api/DMLOptions.java 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2276      +/-   ##
============================================
- Coverage     72.94%   72.56%   -0.39%     
- Complexity    46070    46260     +190     
============================================
  Files          1479     1489      +10     
  Lines        172616   174458    +1842     
  Branches      33783    34266     +483     
============================================
+ Hits         125922   126598     +676     
- Misses        37202    38266    +1064     
- Partials       9492     9594     +102     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mboehm7 mboehm7 closed this in b1c5d64 Aug 20, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in SystemDS PR Queue Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants