Skip to content

Conversation

jessicapriebe
Copy link
Contributor

Add OOCMatrixBlockTracker for encapsulating count maintenance and early block emission

Copy link

codecov bot commented Sep 21, 2025

Codecov Report

❌ Patch coverage is 0% with 51 lines in your changes missing coverage. Please review.
✅ Project coverage is 22.00%. Comparing base (2cb1a60) to head (b17359e).
⚠️ Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
...sysds/runtime/instructions/ooc/OOCInstruction.java 0.00% 23 Missing ⚠️
...instructions/ooc/AggregateUnaryOOCInstruction.java 0.00% 19 Missing ⚠️
...ructions/ooc/MatrixVectorBinaryOOCInstruction.java 0.00% 9 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main    #2318       +/-   ##
=============================================
- Coverage     72.25%   22.00%   -50.26%     
+ Complexity    46625    14808    -31817     
=============================================
  Files          1495     1496        +1     
  Lines        176829   176884       +55     
  Branches      34766    34772        +6     
=============================================
- Hits         127772    38925    -88847     
- Misses        39402   134553    +95151     
+ Partials       9655     3406     -6249     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mboehm7
Copy link
Contributor

mboehm7 commented Sep 21, 2025

LGTM - thanks for the patch @jessicapriebe. This aggregation utility is great and I only slightly changed the naming of member variables.

@mboehm7 mboehm7 closed this in df26e67 Sep 21, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in SystemDS PR Queue Sep 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants