TIKA-4490 (#2350)

* TIKA-4490 -- move the check to the parser level

Author: tballison

tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-mail-module/src/main/java/org/apache/tika/parser/mail/MailContentHandler.java

@@ -128,10 +128,6 @@ public void body(BodyDescriptor body, InputStream is) throws MimeException, IOEx
         if (!extractAllAlternatives && alternativePartBuffer.size() > 0) {
             UnsynchronizedByteArrayOutputStream bos = UnsynchronizedByteArrayOutputStream.builder().get();
             IOUtils.copy(is, bos);
-            byte[] bytes = bos.toByteArray();
-            if (bytes.length == 0) {
-                return;
-            }
             alternativePartBuffer.peek().children.add(new BodyContents(submd, bos.toByteArray()));
         } else if (!extractAllAlternatives && parts.size() < 2) {
             //if you're at the first level of embedding
@@ -141,9 +137,6 @@ public void body(BodyDescriptor body, InputStream is) throws MimeException, IOEx
             UnsynchronizedByteArrayOutputStream bos = UnsynchronizedByteArrayOutputStream.builder().get();
             IOUtils.copy(is, bos);
             final byte[] bytes = bos.toByteArray();
-            if (bytes.length == 0) {
-                return;
-            }
             if (detectInlineTextOrHtml(submd, bytes)) {
                 handleInlineBodyPart(new BodyContents(submd, bytes));
             } else {

tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-mail-module/src/main/java/org/apache/tika/parser/mail/RFC822Parser.java

@@ -31,6 +31,7 @@
 import org.apache.tika.config.Field;
 import org.apache.tika.detect.Detector;
 import org.apache.tika.exception.TikaException;
+import org.apache.tika.exception.ZeroByteFileException;
 import org.apache.tika.extractor.EmbeddedDocumentUtil;
 import org.apache.tika.io.TikaInputStream;
 import org.apache.tika.metadata.Metadata;
@@ -95,6 +96,7 @@ public void parse(InputStream stream, ContentHandler handler, Metadata metadata,
         parser.setNoRecurse();
         xhtml.startDocument();
         TikaInputStream tstream = TikaInputStream.get(stream);
+        checkForZeroByte(tstream);//avoid stackoverflow
         try {
             parser.parse(tstream);
         } catch (IOException e) {
@@ -114,6 +116,17 @@ public void parse(InputStream stream, ContentHandler handler, Metadata metadata,
         xhtml.endDocument();
     }
 
+    private void checkForZeroByte(TikaInputStream tstream) throws IOException, ZeroByteFileException {
+        tstream.mark(1);
+        try {
+            if (tstream.read() < 0) {
+                throw new ZeroByteFileException("rfc822 parser found zero bytes");
+            }
+        } finally {
+            tstream.reset();
+        }
+    }
+
     /**
      * Until version 1.17, Tika handled all body parts as embedded objects (see TIKA-2478).
      * In 1.17, we modified the parser to select only the best alternative body

tika-parsers/tika-parsers-standard/tika-parsers-standard-package/src/test/java/org/apache/tika/ossfuzz/ParserFuzzer.java

@@ -27,7 +27,6 @@
 import org.apache.tika.parser.RecursiveParserWrapper;
 import org.apache.tika.sax.BasicContentHandlerFactory;
 import org.apache.tika.sax.RecursiveParserWrapperHandler;
-
 import org.apache.tika.sax.ToTextContentHandler;