Conversation
Contributor
Author
|
@nddipiazza what do you think? |
tballison
marked this pull request as draft
September 26, 2025 16:53
Contributor
Author
|
I'm converting to draft for now. This is at the "builds on my laptop" stage. |
Contributor
Author
|
One major difference is that tika-pipes-core now brings in jackson for serialization. We could break that into tika-pipes-serialization, but I'm not sure that buys us much. Also, I have some ideas to just pass through json into pipesParser at some point -- instead of deserializing it from json to POJO and then using Java's native serialization to pass it to the pipes-server where it is then deserialized to POJO. 😭 |
Contributor
|
i am looking into this now. |
tballison
marked this pull request as ready for review
September 30, 2025 15:27
Contributor
Author
|
@nddipiazza any objections/recommendations? |
Contributor
|
sorry meant to say i approve and i have based my branch on this |
nddipiazza
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution to Apache Tika! Your help is appreciated!
Before opening the pull request, please verify that
TIKA-XXXX)[TIKA-XXXX] Issue or pull request title)mvn clean testmainbranch. If there are conflicts, please try to rebase the pull request branch on top of a freshly pulledmainbranchtika-bom/pom.xml.We will be able to faster integrate your pull request if these conditions are met. If you have any questions how to fix your problem or about using Tika in general, please sign up for the Tika mailing list. Thanks!