Skip to content

Conversation

tballison
Copy link
Contributor

Thanks for your contribution to Apache Tika! Your help is appreciated!

Before opening the pull request, please verify that

  • there is an open issue on the Tika issue tracker which describes the problem or the improvement. We cannot accept pull requests without an issue because the change wouldn't be listed in the release notes.
  • the issue ID (TIKA-XXXX)
    • is referenced in the title of the pull request
    • and placed in front of your commit messages surrounded by square brackets ([TIKA-XXXX] Issue or pull request title)
  • commits are squashed into a single one (or few commits for larger changes)
  • Tika is successfully built and unit tests pass by running mvn clean test
  • there should be no conflicts when merging the pull request branch into the recent main branch. If there are conflicts, please try to rebase the pull request branch on top of a freshly pulled main branch
  • if you add new module that downstream users will depend upon add it to relevant group in tika-bom/pom.xml.

We will be able to faster integrate your pull request if these conditions are met. If you have any questions how to fix your problem or about using Tika in general, please sign up for the Tika mailing list. Thanks!

@tballison tballison marked this pull request as ready for review October 10, 2025 17:48
@tballison
Copy link
Contributor Author

tballison commented Oct 10, 2025

This is just the first step. It won't build fully yet.

I'm using: mvn clean install -am -pl :tika-fetcher-file-system,tika-app -Dcheckstyle.skip -DskipTests

I have this running with only the file system fetcher and tika-app.

I'm struggling with how to configure the plugins. I'd like to move away from our custom serialization stuff. So, now everything depends on jackson-databind, which adds to dependency bloat but makes the code much cleaner.

For now, I'm putting the file-system-fetcher.json config in the plugin root, and reading it from there. This means that we'll have a bunch of different *.json configs running around, which I don't like.

The current proof of concept only works when using the .jar plugin, not the .zip plugin... ¯_(ツ)_/¯

The big change here is that we can't have multiple fetchers of the same class with different configurations like we used to.

However, users can change the configuration of a given fetcher at runtime by passing in the FileSystemFetcherConfig via the ParseContext.

@nddipiazza would you be willing to take a look and maybe chat?

@tballison tballison marked this pull request as draft October 10, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant