TIKA-4526 - Fix nondeterministic failures in TranslateResourceTest by splitting @PUT/@POST handlers - #2368
Merged
THausherr merged 1 commit intoOct 21, 2025
Conversation
Contributor
|
There's still some double code in the language detection. Can you please add another intermediate method for that? E.g. doAutoTranslate() that calls doTranslate(). |
…splitting @PUT/@post handlers
LucaDai
force-pushed
the
Fix-nondeterministic-failures-in-TranslateResourceTest
branch
from
October 20, 2025 15:12
64db16b to
1fca31e
Compare
Contributor
Author
Thank you for reviewing this PR! I added the doAutoTranslate() method, please check again. |
LucaDai
deleted the
Fix-nondeterministic-failures-in-TranslateResourceTest
branch
November 10, 2025 03:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
**Issue: [TIKA-4526]
Type of change
Summary
The failure was caused by ambiguous method mappings in TranslateResource, where both the
translateandautoTranslatemethods were annotated with both @put and @post at the same time.A similar issue was fixed in the previous merged PR, which included a detailed explanation and how to reproduce:
#2360
Related Tests
Verification
mvn test -pl tika-server/tika-server-corepasses.-DnondexRuns=100) pass with no flakes.Please let me know if anything needs to change regarding the code style.