Skip to content

TIKA-4704: add delete on exit in case delete fails #2717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
THausherr merged 2 commits into from
Mar 29, 2026
+3 −1
Merged

TIKA-4704: add delete on exit in case delete fails #2717

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35824cc
TIKA-4704: delete on exit in case delete fails
THausherr Mar 29, 2026
9d994dc
delete on exit only if really needed
THausherr Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tika-core/src/main/java/org/apache/tika/fork/ForkClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,7 @@ public synchronized void close() {
}
if (jar != null) {
jar.delete();
jar.deleteOnExit();
Comment thread
THausherr marked this conversation as resolved.
Outdated

Copilot AI Mar 29, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File#deleteOnExit() can throw SecurityException. Since close() currently doesn’t declare/expect to throw and is used in failure-cleanup paths, this new call can cause unexpected runtime failure during cleanup. Please guard the deleteOnExit() call (and any conditional logic around it) to keep close() best-effort.

Suggested change
jar.deleteOnExit();
try {
jar.deleteOnExit();
} catch (SecurityException ignore) {
// best-effort cleanup; ignore inability to register deleteOnExit
}

Copilot uses AI. Check for mistakes.

@THausherr THausherr Mar 29, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There shouldn't be a SecurityException because it's our own file.

}
}

Expand Down
Loading