Skip to content

TIKA-4703: Fix tika-grpc Docker image missing runtime dependencies #2790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nddipiazza merged 4 commits into from
Apr 27, 2026
+108 −4
Merged

TIKA-4703: Fix tika-grpc Docker image missing runtime dependencies #2790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8b6dd80
TIKA-4703: Fix tika-grpc Docker image missing runtime dependencies
nddipiazza Apr 27, 2026
7bd2ad4
TIKA-4703: Rename lib dir to tika-grpc, consolidate dep step, add grp…
nddipiazza Apr 27, 2026
acd2d73
TIKA-4703: Add smoke tests for tika-server minimal and full Docker im…
nddipiazza Apr 27, 2026
cf1d3f3
TIKA-4703: Fix assembly.xml dep dir and use trap-based cleanup in smo…
nddipiazza Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/docker-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,12 @@ jobs:
TIKA_VERSION="${{ steps.version.outputs.tag }}"
OUT_DIR=target/tika-grpc-docker

mkdir -p "${OUT_DIR}/libs" "${OUT_DIR}/plugins" "${OUT_DIR}/config" "${OUT_DIR}/bin"
mkdir -p "${OUT_DIR}/libs/tika-grpc" "${OUT_DIR}/plugins" "${OUT_DIR}/config" "${OUT_DIR}/bin"

cp "tika-grpc/target/tika-grpc-${TIKA_VERSION}.jar" "${OUT_DIR}/libs/"
mvn -pl tika-grpc dependency:copy-dependencies \
-DoutputDirectory="${PWD}/${OUT_DIR}/libs/tika-grpc" \
-DincludeScope=runtime -q -B

# Copy tika-pipes plugin zip files
for dir in tika-pipes/tika-pipes-plugins/*/; do
Expand Down
103 changes: 102 additions & 1 deletion .github/workflows/docker-snapshot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,38 @@ jobs:
tar xzf "tika-server/tika-server-standard/target/tika-server-standard-${TIKA_VERSION}-bin.tgz" -C "${OUT_DIR}/tika-server"
cp "tika-server/docker-build/minimal/Dockerfile.snapshot" "${OUT_DIR}/Dockerfile"

- name: Build tika-server minimal image for smoke test
uses: docker/build-push-action@10e90e3645eae34f1e60eeb005ba3a3d33f178e8 # v6.19.2
with:
context: target/tika-server-minimal-docker
platforms: linux/amd64
load: true
build-args: |
TIKA_VERSION=${{ steps.version.outputs.tika_version }}
tags: tika-server-minimal-smoke:ci

- name: Smoke test tika-server minimal image
run: |
cleanup() {
status=$?
if [ "$status" -ne 0 ]; then
docker logs tika-server-minimal-smoke || true
fi
docker rm -f tika-server-minimal-smoke >/dev/null 2>&1 || true
exit "$status"
}
trap cleanup EXIT
docker run -d --name tika-server-minimal-smoke -p 9998:9998 tika-server-minimal-smoke:ci
for i in $(seq 1 20); do
if docker logs tika-server-minimal-smoke 2>&1 | grep -q "Started Apache Tika server"; then
echo "tika-server minimal started successfully"
exit 0
fi
sleep 2
done
echo "ERROR: tika-server minimal did not start within 40 seconds"
exit 1

- name: Build and push tika-server minimal snapshot
uses: docker/build-push-action@10e90e3645eae34f1e60eeb005ba3a3d33f178e8 # v6.19.2
with:
Expand All @@ -89,6 +121,38 @@ jobs:
tar xzf "tika-server/tika-server-standard/target/tika-server-standard-${TIKA_VERSION}-bin.tgz" -C "${OUT_DIR}/tika-server"
cp "tika-server/docker-build/full/Dockerfile.snapshot" "${OUT_DIR}/Dockerfile"

- name: Build tika-server full image for smoke test
uses: docker/build-push-action@10e90e3645eae34f1e60eeb005ba3a3d33f178e8 # v6.19.2
with:
context: target/tika-server-full-docker
platforms: linux/amd64
load: true
build-args: |
TIKA_VERSION=${{ steps.version.outputs.tika_version }}
tags: tika-server-full-smoke:ci

- name: Smoke test tika-server full image
run: |
cleanup() {
status=$?
if [ "$status" -ne 0 ]; then
docker logs tika-server-full-smoke || true
fi
docker rm -f tika-server-full-smoke >/dev/null 2>&1 || true
exit "$status"
}
trap cleanup EXIT
docker run -d --name tika-server-full-smoke -p 9999:9998 tika-server-full-smoke:ci
for i in $(seq 1 20); do
if docker logs tika-server-full-smoke 2>&1 | grep -q "Started Apache Tika server"; then
echo "tika-server full started successfully"
exit 0
fi
sleep 2
done
echo "ERROR: tika-server full did not start within 40 seconds"
exit 1

- name: Build and push tika-server full snapshot
uses: docker/build-push-action@10e90e3645eae34f1e60eeb005ba3a3d33f178e8 # v6.19.2
with:
Expand All @@ -106,9 +170,12 @@ jobs:
TIKA_VERSION="${{ steps.version.outputs.tika_version }}"
OUT_DIR=target/tika-grpc-docker

mkdir -p "${OUT_DIR}/libs" "${OUT_DIR}/plugins" "${OUT_DIR}/config" "${OUT_DIR}/bin"
mkdir -p "${OUT_DIR}/libs/tika-grpc" "${OUT_DIR}/plugins" "${OUT_DIR}/config" "${OUT_DIR}/bin"

cp "tika-grpc/target/tika-grpc-${TIKA_VERSION}.jar" "${OUT_DIR}/libs/"
mvn -pl tika-grpc dependency:copy-dependencies \
-DoutputDirectory="${PWD}/${OUT_DIR}/libs/tika-grpc" \
-DincludeScope=runtime -q -B

# Copy tika-pipes plugin zip files
for dir in tika-pipes/tika-pipes-plugins/*/; do
Expand All @@ -135,6 +202,40 @@ jobs:
cp "tika-grpc/docker-build/start-tika-grpc.sh" "${OUT_DIR}/bin/"
cp "tika-grpc/docker-build/Dockerfile" "${OUT_DIR}/Dockerfile"

- name: Build tika-grpc image for smoke test
uses: docker/build-push-action@10e90e3645eae34f1e60eeb005ba3a3d33f178e8 # v6.19.2
with:
context: target/tika-grpc-docker
platforms: linux/amd64
load: true
build-args: |
VERSION=${{ steps.version.outputs.tika_version }}
tags: tika-grpc-smoke:ci

- name: Smoke test tika-grpc image
run: |
cleanup() {
status=$?
if [ "$status" -ne 0 ]; then
docker logs tika-grpc-smoke || true
docker ps -a --filter "name=^tika-grpc-smoke$" || true
docker inspect -f '{{.State.ExitCode}}' tika-grpc-smoke || true
fi
docker rm -f tika-grpc-smoke >/dev/null 2>&1 || true
exit "$status"
}
trap cleanup EXIT
docker run -d --name tika-grpc-smoke -p 9090:9090 tika-grpc-smoke:ci
for i in $(seq 1 15); do
if docker logs tika-grpc-smoke 2>&1 | grep -q "Server started, listening on"; then
echo "tika-grpc started successfully"
exit 0
fi
sleep 2
done
echo "ERROR: tika-grpc did not start within 30 seconds"
exit 1

- name: Build and push tika-grpc snapshot
uses: docker/build-push-action@10e90e3645eae34f1e60eeb005ba3a3d33f178e8 # v6.19.2
with:
Expand Down
2 changes: 1 addition & 1 deletion tika-grpc/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,7 @@
<manifest>
<mainClass>org.apache.tika.pipes.grpc.TikaGrpcServer</mainClass>
<addClasspath>true</addClasspath>
<classpathPrefix>lib/</classpathPrefix>
<classpathPrefix>tika-grpc/</classpathPrefix>
Comment thread
nddipiazza marked this conversation as resolved.
</manifest>
</archive>
</configuration>
Expand Down
2 changes: 1 addition & 1 deletion tika-grpc/src/main/assembly/assembly.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@

<dependencySets>
<dependencySet>
<outputDirectory>lib</outputDirectory>
<outputDirectory>tika-grpc</outputDirectory>
<useProjectArtifact>false</useProjectArtifact>
<unpack>false</unpack>
<scope>runtime</scope>
Expand Down
Loading