Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes TIKA-4734 by ensuring --convert-config-xml-to-json is treated as a standalone CLI utility (not routed into Tika Pipes/async mode) and by changing the conversion output behavior to write JSON to stdout for shell redirection.
Changes:
- Prevent async-mode auto-detection from triggering when
--convert-config-xml-to-json=...is present. - Change
--convert-config-xml-to-jsonto accept only an input XML path and emit the converted JSON to stdout (with updated CLI help text). - Add a CLI regression test and update the 4.x migration docs to reflect the new invocation pattern.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tika-app/src/test/java/org/apache/tika/cli/TikaCLITest.java | Adds a regression test asserting that XML→JSON conversion runs standalone and prints JSON to stdout. |
| tika-app/src/main/java/org/apache/tika/cli/TikaCLI.java | Adjusts async detection and updates the conversion implementation and CLI usage text for stdout output. |
| docs/modules/ROOT/pages/migration-to-4x/migrating-to-4x.adoc | Updates migration guide example to use stdout redirection and notes no separate --config is required. |
Comments suppressed due to low confidence (1)
tika-app/src/main/java/org/apache/tika/cli/TikaCLI.java:408
- In testForAsync(), the heuristic
args.length == 1 && args[0].endsWith(".json")will also match option arguments like--config=...json, which should be handled by the normal CLI (process() parses--config=) rather than routing into async mode. Consider tightening this check (e.g., require the arg not to start with '-' / be a real path) to avoid misclassifying single-option invocations.
// Single .json file is a config file for async mode
if (args.length == 1 && args[0].endsWith(".json")) {
return true;
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution to Apache Tika! Your help is appreciated!
Before opening the pull request, please verify that
TIKA-XXXX)[TIKA-XXXX] Issue or pull request title)./mvnw clean testmainbranch. If there are conflicts, please try to rebase the pull request branch on top of a freshly pulledmainbranchtika-bom/pom.xml.We will be able to faster integrate your pull request if these conditions are met. If you have any questions how to fix your problem or about using Tika in general, please sign up for the Tika mailing list. Thanks!