Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses TIKA-4752 by improving how ZipParser determines ZIP entry names when UTF-8 is indicated by ZIP metadata. It adds focused tests to ensure ZIP entry-name decoding honors both the EFS (UTF-8) flag and the Unicode path extra field, and extends MetadataCharsetDetector so charset declarations can be sourced from CONTENT_TYPE_HINT.
Changes:
- Update
ZipParserto trust commons-compress’s CRC-validated Unicode extra-field names and to pass an EFS-derived UTF-8 hint into the encoding-detector chain when charset detection is enabled. - Extend
MetadataCharsetDetectorto consultTikaCoreProperties.CONTENT_TYPE_HINT(betweenMetadata.CONTENT_TYPEandMetadata.CONTENT_ENCODING). - Add unit tests covering the new ZIP entry-name behavior and the new
MetadataCharsetDetectorprecedence rules.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tika-parsers/.../ZipEntryNameEncodingTest.java |
New tests validating ZIP entry-name decoding via EFS flag hinting and Unicode extra-field handling. |
tika-parsers/.../ZipParser.java |
Entry-name detection changes to honor Unicode extra fields and use EFS as a UTF-8 hint for charset detection. |
tika-core/src/test/.../MetadataCharsetDetectorTest.java |
New tests for CONTENT_TYPE_HINT handling and precedence vs CONTENT_TYPE and CONTENT_ENCODING. |
tika-core/src/main/.../MetadataCharsetDetector.java |
Adds CONTENT_TYPE_HINT as an additional metadata source for declarative charset detection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution to Apache Tika! Your help is appreciated!
Before opening the pull request, please verify that
TIKA-XXXX)[TIKA-XXXX] Issue or pull request title)./mvnw clean testmainbranch. If there are conflicts, please try to rebase the pull request branch on top of a freshly pulledmainbranchtika-bom/pom.xml.We will be able to faster integrate your pull request if these conditions are met. If you have any questions how to fix your problem or about using Tika in general, please sign up for the Tika mailing list. Thanks!