[TIKA-4849] Unnecessary dependencies to jaxb-runtime removed - #3088
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes now-unneeded explicit org.glassfish.jaxb:jaxb-runtime dependencies from two Tika parser modules to reduce dependency footprint, aligning with TIKA-4849’s goal of eliminating legacy JAXB runtime usage where it’s no longer required.
Changes:
- Removed
org.glassfish.jaxb:jaxb-runtimefromtika-parser-pdf-module. - Removed
org.glassfish.jaxb:jaxb-runtimefromtika-parser-miscoffice-module.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-pdf-module/pom.xml | Drops the explicit jaxb-runtime dependency from the PDF parser module’s Maven dependencies. |
| tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-miscoffice-module/pom.xml | Drops the explicit jaxb-runtime dependency from the miscellaneous office parser module’s Maven dependencies. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
I'll run a local test with docker just to be sure. |
Contributor
|
I'm having troubles building but I think that's another problem which I'll research separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes TIKA-4849: Unnecessary dependencies to jaxb-runtime:
Two parser modules (tika-parser-miscoffice-module and tika-parser-pdf-module) still contain a depenency to jaxb-runtime although this isn't needed (anymore).
I verified that the build still works by executing "mvn clean verify" on my fork.