Skip to content

[TIKA-4848] Fix expected output in ExceptionUtilsTest to account for … - #3089

Merged
THausherr merged 1 commit into
mainfrom
TIKA-4848
Aug 28, 2026
Merged

[TIKA-4848] Fix expected output in ExceptionUtilsTest to account for …#3089
THausherr merged 1 commit into
mainfrom
TIKA-4848

Conversation

@THausherr

Copy link
Copy Markdown
Contributor

…Windows line endings.

Thanks for your contribution to Apache Tika! Your help is appreciated!

Before opening the pull request, please verify that

  • there is an open issue on the Tika issue tracker which describes the problem or the improvement. We cannot accept pull requests without an issue because the change wouldn't be listed in the release notes.
  • the issue ID (TIKA-XXXX)
    • is referenced in the title of the pull request
    • and placed in front of your commit messages surrounded by square brackets ([TIKA-XXXX] Issue or pull request title)
  • commits are squashed into a single one (or few commits for larger changes)
  • Tika builds and unit tests pass with ./mvnw clean install (clean test alone cannot resolve the pipes plugin zips)
  • if you used a generative AI tool: follow the ASF Generative Tooling Guidance (Generated-by: <tool> in the commit message), and consider running the pre-flight in .skills/devs/pr-review/SKILL.md — fix what it finds; don't paste its report here
  • there should be no conflicts when merging the pull request branch into the recent main branch. If there are conflicts, please try to rebase the pull request branch on top of a freshly pulled main branch
  • if you add new module that downstream users will depend upon add it to relevant group in tika-bom/pom.xml.

We will be able to faster integrate your pull request if these conditions are met. If you have any questions how to fix your problem or about using Tika in general, please sign up for the Tika mailing list. Thanks!

Copilot AI lite review requested due to automatic review settings August 28, 2026 08:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates ExceptionUtilsTest to make the messageRedactedEqualsFullMinusMessages() assertion stable across platforms by normalizing Windows CRLF line endings in the expected string derived from Throwable#printStackTrace() output.

Changes:

  • Strip \r characters from the expected stack trace string before comparing it to the redacted output.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@THausherr
THausherr merged commit ba4d312 into main Aug 28, 2026
5 checks passed
@tballison

Copy link
Copy Markdown
Contributor

Gah. Thank you. Will move windows back to the PR ci...sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants