Skip to content

TIKA-4853: DWGReadParser emits the drawing thumbnail as THUMBNAIL #3092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
THausherr merged 3 commits into from
Aug 29, 2026
+9 −4
Merged

TIKA-4853: DWGReadParser emits the drawing thumbnail as THUMBNAIL #3092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
00a2aaf
TIKA-4853 - the DWG thumbnail is a THUMBNAIL embedded document
dschmidt Aug 29, 2026
24cbbef
Potential fix for pull request finding
THausherr Aug 29, 2026
e884a05
Merge branch 'main' into dwg-thumbnail
THausherr Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
Release 4.1.0 - unreleased

* DWGReadParser emits the drawing's THUMBNAILIMAGE as a THUMBNAIL embedded
document instead of INLINE (TIKA-4853).

* EpubParser emits the cover image named by the OPF (the EPUB 3
cover-image manifest property, or the EPUB 2 cover meta) as a THUMBNAIL
embedded document (TIKA-4852).
Expand Down
3 changes: 2 additions & 1 deletion ...odules/tika-parser-cad-module/src/main/java/org/apache/tika/parser/dwg/DWGReadParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,8 +416,9 @@ private void parseThumbnail(JsonParser jsonParser, XHTMLContentHandler xhtml,
EmbeddedDocumentUtil.getEmbeddedDocumentExtractor(context);
Metadata embeddedMetadata = new Metadata();
embeddedMetadata.set(TikaCoreProperties.RESOURCE_NAME_KEY, "thumbnail");
// The drawing's preview image, not a picture placed in the drawing
embeddedMetadata.set(TikaCoreProperties.EMBEDDED_RESOURCE_TYPE,
TikaCoreProperties.EmbeddedResourceType.INLINE.toString());
TikaCoreProperties.EmbeddedResourceType.THUMBNAIL.toString());
if (!embeddedDocumentExtractor.shouldParseEmbedded(embeddedMetadata, context)) {
return;
}
Expand Down
7 changes: 4 additions & 3 deletions ...odules/tika-parser-cad-module/src/test/java/org/apache/tika/parser/dwg/DWGParserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,16 +276,17 @@ public void testDWGReadexe() throws Exception {
assertNotNull(root.get(DWG.APPLICATION_COMMENT));
assertContains("AutoCAD", root.get(DWG.PRODUCT_INFO));

// Thumbnail embedded as INLINE
// the THUMBNAILIMAGE section is the drawing's THUMBNAIL embedded document
Metadata thumb = null;
for (int i = 1; i < metadataList.size(); i++) {
String type = metadataList.get(i).get(TikaCoreProperties.EMBEDDED_RESOURCE_TYPE);
if (TikaCoreProperties.EmbeddedResourceType.INLINE.name().equals(type)) {
if (TikaCoreProperties.EmbeddedResourceType.THUMBNAIL.name().equals(type)) {
thumb = metadataList.get(i);
break;
}
}
assertNotNull(thumb, "Expected an INLINE thumbnail attachment");
assertNotNull(thumb, "Expected a THUMBNAIL embedded document");
assertEquals("thumbnail", thumb.get(TikaCoreProperties.RESOURCE_NAME_KEY));
}

@Test
Expand Down