#677 - Add explicit ciphers, kex and mac algorithms.#689
Open
#677 - Add explicit ciphers, kex and mac algorithms.#689
Conversation
alitheg
force-pushed
the
ssh_security_config
branch
from
a94451d to
1c982ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've created a PR for this one as I wanted to validate the choices. I tried to follow the defaults (which are slightly more broad than the original suggestion in #677) because that way we maintain the same compatibility we have today, however for the key exchange algorithms, the
asyncsshmodule checks to see which capabilities are available and changes some of those defaults dynamically. We could do that checking ourselves but that feels unnecessary to me unless we specifically want to allow some of those options - hence please let me know what if any you'd like to add or remove from these lists!