Remove use of psql from traffic_ops/db/admin
#5327
Conversation
updated dropDB in app/db/admin.go to use pgx+dburl created connectAndExecute to deduplicate in app/db/admin.go replaced all use of psql binary (and dropuser) wrapped up most querying into a single function (connectAndExecute) still need to write tests and handle vendoring added github.com/xo/dburl to vendor.json added xo/dburl files to vendor cleaned up a little, added return statement added dburl/xo MIT license entry to LICENSE gave some credit where it was due reintroduced hostport, removed role attributes portion of query
MylesBock
changed the title
psql from traffic_ops/db/admin
|
Converted to draft, need to figure out what's up with CIAB starting up |
rawlinp
added
database
| //todo determine test coverage of this portion | ||
| if db, err := dburl.Open(fmt.Sprintf("pg://%s:%s@%s:%s/", DBSuperUser, DBPassword, HostIP, HostPort)); err == nil { | ||
| if !returnRows { | ||
| if _, err := db.Exec(query); err != nil { |
There was a problem hiding this comment.
So some of our files like seeds.sql contain multiple sql queries. Doesn't this only execute a single sql query?
There was a problem hiding this comment.
Correct, but in this case it's reading an entire file in for things like patch, seed, create and executing it all at once
This has come up apparently in a few discussions on lib/pq and other repositories related to golang and postgres, and one project offers a solution (https://github.com/gchaincl/dotsql) but it requires more effort
There was a problem hiding this comment.
If it's preferred I could parse in the DML/DDL files and break them down into individual queries
There was a problem hiding this comment.
Wow, I thought db.Exec would return after running only a single query, hence making it not work for files like seeds.sql which have multiple queries. If that works, I'm fine with that -- no need to break them down into individual queries.
There was a problem hiding this comment.
I'm 99% sure this is why ciab doesn't come up in the pipeline though, so I'll break it down into individual queries or use dotsql
What does this PR (Pull Request) do?
Replaces use of
psqlanddropuserwithdburlandlib/pq.Test coverage is unknown
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run the
traffic_ops/db/adminutility against a postgres instance, ensure the multiline SQL queries do not break anythingIf this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR
Additional Information