-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use "twelve" as the password where "twelve12" was used #7149
base: master
Are you sure you want to change the base?
Conversation
I don't agree that we should knowingly use invalid data in any environment, except in a test to ensure such data is rejected by the API. |
how about using |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7149 +/- ##
=============================================
+ Coverage 28.96% 65.64% +36.68%
Complexity 98 98
=============================================
Files 602 323 -279
Lines 77452 12836 -64616
Branches 90 970 +880
=============================================
- Hits 22432 8426 -14006
+ Misses 52926 4050 -48876
+ Partials 2094 360 -1734
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
If |
#4764 changed the default password in some places, but not all, from
twelve
totwelve12
. This is confusing for all of the people who are used totwelve
being the default password for all components of the project. This PR reverts all instances oftwelve12
totwelve
.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Verify the tests pass
PR submission checklist