Colin support read tree #643
Open
+1,401
−561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColinLeeo
force-pushed
the
colin_support_read_tree
branch
2 times, most recently
from
11b9469 to
0df919d
Compare
ColinLeeo
force-pushed
the
colin_support_read_tree
branch
from
0df919d to
7ef45b5
Compare
hongzhi-gao
reviewed
Nov 21, 2025
| int column_pos_in_id = | ||
| table_schema->find_id_column_order(id_column) + 1; | ||
| int column_pos_in_id = table_schema->find_id_column_order(id_column) + | ||
| (!table_schema->is_virtual_table()); |
Contributor
There was a problem hiding this comment.
int column_pos_in_id = table_schema->find_id_column_order(id_column) +
(table_schema->is_virtual_table() ? 0 : 1);
hongzhi-gao
approved these changes
Nov 21, 2025
jt2594838
reviewed
Nov 24, 2025
Comment on lines
102
to
105
| if (RET_FAIL(file_meta->get_table_metaindex_node( | ||
| device->get_table_name(), table_inode))) { | ||
| }; | ||
| table_inodes.push_back(table_inode); |
Contributor
There was a problem hiding this comment.
Should return the failure？
Comment on lines
+119
to
+122
| if (column_types_map.find(field_col) == column_types_map.end()) { | ||
| all_collected = false; | ||
| break; | ||
| } |
Contributor
There was a problem hiding this comment.
How about type collision？
Comment on lines
131
to
134
| if (RET_FAIL(tsfile_io_reader_->get_timeseries_indexes( | ||
| device, measurements, index, pa))) { | ||
| assert(0); | ||
| } |
Contributor
There was a problem hiding this comment.
Should return the failure?
Comment on lines
+142
to
+152
| common::TSDataType type = ts_index->get_data_type(); | ||
| // TODO(Colin): Fix type missmatch. | ||
| // if (type == common::TSDataType::INT32 || | ||
| // type == common::TSDataType::INT64 || | ||
| // type == common::TSDataType::TIMESTAMP || | ||
| // type == common::TSDataType::DATE) { | ||
| // type = common::TSDataType::INT64; | ||
| // } else if (type == common::TSDataType::FLOAT) { | ||
| // type = common::TSDataType::DOUBLE; | ||
| // } | ||
| column_types_map[measurement_name] = type; |
cpp/src/reader/tsfile_reader.cc
Outdated
| } | ||
| std::vector<std::string> columns_names(max_len); | ||
| for (int i = 0; i < max_len; i++) { | ||
| columns_names[i] = "l_" + std::to_string(i); |
Contributor
There was a problem hiding this comment.
Use "__L" to reduce the possiblity of conflicting with the user column.
ColinLeeo
force-pushed
the
colin_support_read_tree
branch
from
a4d33a0 to
c5d1410
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.