Feature/python new datatypes (#641) #644
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [Python] new datatypes * add cwrapper ut for python new datatypes
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #644 +/- ##
===========================================
+ Coverage 62.34% 62.49% +0.15%
===========================================
Files 703 704 +1
Lines 39628 39819 +191
Branches 5537 5571 +34
===========================================
+ Hits 24705 24885 +180
+ Misses 14261 14246 -15
- Partials 662 688 +26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jt2594838
reviewed
Nov 24, 2025
cpp/src/cwrapper/tsfile_cwrapper.h
Outdated
Comment on lines
629
to
631
| ERRNO _insert_data_into_ts_record_by_name_string(TsRecord data, | ||
| const char* measurement_name, | ||
| const char* value); |
Contributor
There was a problem hiding this comment.
Do we really need to provide such an insecure method?
cpp/test/cwrapper/cwrapper_test.cc
Outdated
| // Verify the retrieved data matches what we inserted | ||
| bool has_next = false; | ||
| int row_count = 0; | ||
| while (!result->next(has_next) && has_next) { |
Contributor
There was a problem hiding this comment.
Rewrite !result->next(has_next) to make it clear that it is checking the status code.
python/tsfile/tsfile_cpp.pxd
Outdated
| ErrorCode _insert_data_into_ts_record_by_name_string_with_len(TsRecord data, const char *measurement_name, | ||
| const char *value, | ||
| const uint32_t value_len); | ||
| #ErrorCode _insert_data_into_ts_record_by_name_blob(record, PyUnicode_AsUTF8(field.get_field_name()), field.get_bytes_value()) |
python/tsfile/tsfile_py_cpp.pyx
Outdated
Comment on lines
271
to
273
| # STRING or TEXT | ||
| elif data_type == TS_DATATYPE_STRING or data_type == TS_DATATYPE_TEXT or data_type == TS_DATATYPE_BLOB: | ||
| for row in range(max_row_num): |
ColinLeeo
force-pushed
the
feature/python-new-datatypes
branch
from
db78d02 to
bc7e1b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Python] new datatypes
add cwrapper ut for python new datatypes