[Relax][ONNX] Add edge padding mode #18575
Open
+8
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Summary of ChangesHello @guan404ming, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the ONNX frontend by introducing support for the 'edge' padding mode. This addition improves the compatibility and robustness of the frontend when handling ONNX models that specify 'edge' padding, ensuring that such models can be correctly processed without encountering unimplemented feature errors. The change involves updating the padding logic and adding comprehensive tests to validate the new functionality. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements support for the "edge" padding mode in the ONNX Pad operator within onnx_frontend.py by replacing a NotImplementedError with a call to topi.nn.replicate_pad for both _impl_v2 and _impl_v11 methods. Corresponding test cases for this new "edge" mode were added to test_frontend_onnx.py. The reviewer commented that these new test cases were duplicated across test_pad and test_pad_v2 and suggested merging these into a single parameterized test to improve maintainability.
Comment on lines
+2443
to
+2444
| verify_pad((2, 3), [1, 1, 1, 1], "edge") | ||
| verify_pad((1, 3, 4, 5), [0, 1, 1, 1, 0, 0, 1, 1], "edge") |
Contributor
There was a problem hiding this comment.
These test cases for 'edge' padding are also added to test_pad_v2. To avoid code duplication, consider merging test_pad and test_pad_v2 into a single parameterized test that takes the ONNX opset version as a parameter. This would make the tests more maintainable.
Member
Author
mshr-h
approved these changes
Dec 10, 2025
Member
Author
|
Thanks, the ci seems down for a while. |
Contributor
|
Looks like the CI is down. Can you check it? @tqchen @MasterJH5574 @Hzfengsy |
Contributor
|
@tvm-bot rerun |
Contributor
|
Failed to re-run CI in https://github.com/apache/tvm/actions/runs/20171211393 Detailswith response |
guan404ming
force-pushed
the
onnx-edge-pad
branch
from
7d0f8ac to
f4323d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How