Skip to content

[Relax] Correct YaRN RoPE frequency scaling formula to align with the original paper #18576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Liberatedwinner wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −9
Open

[Relax] Correct YaRN RoPE frequency scaling formula to align with the original paper #18576

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ac79ba
[Relax] Refactor position embedding calculations
Liberatedwinner Dec 10, 2025
8b07e0f
Update python/tvm/relax/frontend/nn/llm/position_embedding.py
Liberatedwinner Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions python/tvm/relax/frontend/nn/llm/position_embedding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,8 +197,8 @@ def yarn_find_correction_range(
max_position_embeddings: int,
):
"""Find the correction range based on the number of rotations"""
low = tir.floor(yarn_find_correction_dim(low_rot, d, theta, max_position_embeddings))
high = tir.ceil(yarn_find_correction_dim(high_rot, d, theta, max_position_embeddings))
low = yarn_find_correction_dim(low_rot, d, theta, max_position_embeddings)
high = yarn_find_correction_dim(high_rot, d, theta, max_position_embeddings)
return tir.max(low, 0), tir.min(high, d - 1)


Expand All @@ -214,16 +214,15 @@ def rope_freq_yarn(
beta_slow: int,
): # pylint: disable=too-many-arguments, too-many-locals
"""Compute the inverse frequency of RoPE for yarn RoPE scaling."""
freq_extra = tir.const(1, "float32") / tir.power(
theta, d * 2 % d_range / tir.const(d_range, "float32")
)

freq_inter = tir.const(1, "float32") / tir.power(
scaling_factor * theta, d * 2 % d_range / tir.const(d_range, "float32")
)
exponent = d * 2 % d_range / tir.const(d_range, "float32")
freq_power = tir.power(theta, exponent)

freq_extra = tir.const(1, "float32") / freq_power
freq_inter = tir.const(1, "float32") / (scaling_factor * freq_power)

low, high = yarn_find_correction_range(
beta_fast, beta_slow, d, theta, original_max_position_embeddings
beta_fast, beta_slow, d_range, theta, original_max_position_embeddings
)
high = tir.if_then_else(low == high, high + 0.001, high)
inv_freq_mask = tir.const(1, "float32") - tir.max(
Expand Down