Skip to content

Add default toJson argument for explain #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juripetersen merged 2 commits into from
Apr 10, 2025
Merged

Add default toJson argument for explain #541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e30368
Add default toJson argument for explain
juripetersen Apr 10, 2025
a9c4ba9
Add buildAndExplain with toJson args to PlanBuilder
juripetersen Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions wayang-api/wayang-api-scala-java/src/main/scala/org/apache/wayang/api/DataQuanta.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -942,7 +942,7 @@ class DataQuanta[Out: ClassTag](val operator: ElementaryOperator, outputIndex: I
collector
}

def explain(): Unit = {
def explain(toJson: Boolean = false): Unit = {
// Set up the sink.
val collector = new java.util.LinkedList[Out]()
val sink = LocalCallbackSink.createCollectingSink(collector, dataSetType[Out])
Expand All @@ -951,7 +951,7 @@ class DataQuanta[Out: ClassTag](val operator: ElementaryOperator, outputIndex: I

// Do the explanation.
this.planBuilder.sinks += sink
this.planBuilder.buildAndExplain()
this.planBuilder.buildAndExplain(toJson)
}


Expand Down
8 changes: 6 additions & 2 deletions wayang-api/wayang-api-scala-java/src/main/scala/org/apache/wayang/api/PlanBuilder.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,13 @@ class PlanBuilder(private[api] val wayangContext: WayangContext, private var job
/**
* Build the [[org.apache.wayang.core.api.Job]] and explain it.
*/
def buildAndExplain(): Unit = {
def buildAndExplain(toJson: Boolean = false): Unit = {
val plan: WayangPlan = new WayangPlan(this.sinks.toArray: _*)
this.wayangContext.explain(plan, this.udfJars.toArray: _*)
if (toJson) {
this.wayangContext.explain(plan, toJson, this.udfJars.toArray: _*)
} else {
this.wayangContext.explain(plan, this.udfJars.toArray: _*)
}
}

/**
Expand Down
Loading