Serialisation for aggregation in sql-api & improvements to various tests#558
Merged
Conversation
juripetersen
approved these changes
May 2, 2025
novatechflow
approved these changes
May 2, 2025
Member
novatechflow
left a comment
novatechflow
left a comment
There was a problem hiding this comment.
+1 - one idea maybe, for uncheckedIOException could we add a explanation? Like permissions, file / table not found etc? Just an idea, no blocker!
Contributor
Author
|
@2pk03 you mean the one in This just seems like dead code, I dunno that it has any usage either tbh. |
Member
|
Ah, good, so we remove it in one of the next commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.