Skip to content

Add explain to json config to Job #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zkaoudi merged 1 commit into from
May 8, 2025
Merged

Add explain to json config to Job #562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions wayang-api/wayang-api-scala-java/src/main/scala/org/apache/wayang/api/PlanBuilder.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,13 @@ class PlanBuilder(private[api] val wayangContext: WayangContext, private var job
*/
def buildAndExecute(): Unit = {
val plan: WayangPlan = new WayangPlan(this.sinks.toArray: _*)
if (this.experiment == null) this.wayangContext.execute(jobName, plan, this.udfJars.toArray: _*)
else this.wayangContext.execute(jobName, plan, this.experiment, this.udfJars.toArray: _*)

if (this.experiment == null) {
this.wayangContext.execute(jobName, plan, this.udfJars.toArray: _*)
}
else {
this.wayangContext.execute(jobName, plan, this.experiment, this.udfJars.toArray: _*)
}
}

/**
Expand Down
11 changes: 11 additions & 0 deletions wayang-commons/wayang-core/src/main/java/org/apache/wayang/core/api/Job.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@
import org.apache.wayang.core.util.OneTimeExecutable;
import org.apache.wayang.core.util.ReflectionUtils;
import org.apache.wayang.core.util.WayangCollections;
import org.apache.wayang.core.util.ExplainUtils;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;

Expand Down Expand Up @@ -304,6 +305,16 @@ protected void doExecute() {
this.logger.warn("Failed to initialize monitor: {}", e);
}

if (this.configuration.getBooleanProperty("wayang.core.explain.enabled")) {
ExplainUtils.write(
ExplainUtils.parsePlan(this.wayangPlan, true),
this.configuration.getStringProperty("wayang.core.explain.logical.file")
);
ExplainUtils.write(
ExplainUtils.parsePlan(executionPlan, true),
this.configuration.getStringProperty("wayang.core.explain.execution.file")
Copy link
Copy Markdown
Contributor

@zkaoudi zkaoudi May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if the user did not specify the file path?

);
}

// Take care of the execution.
while (!this.execute(executionPlan, executionId)) {
Expand Down
1 change: 1 addition & 0 deletions wayang-commons/wayang-core/src/main/resources/wayang-core-defaults.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ wayang.core.optimizer.enumeration.branchesfirst = false
wayang.core.log.enabled = true
# wayang.core.log.cardinalities = ~/.wayang/cardinalities.json
# wayang.core.log.executions = ~/.wayang/executions.json
wayang.core.explain.enabled = false

# Configure re-optimization.
wayang.core.optimizer.reoptimize = false
Expand Down
Loading