Ensure deterministic plan enumeration and channel conversion #662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rdered sets for scope/slot tracking, add stable cost tiebreaker, and cover with determinism tests.
Closed
|
|
||
| private static String describeInputSlot(InputSlot<?> slot) { | ||
| if (slot == null) { | ||
| return "null"; |
Contributor
There was a problem hiding this comment.
Couldn't this just return an actual null then? String is nullable, so this can be a valid value.
Or would this be a problem on comparison later on?
Member
Author
There was a problem hiding this comment.
Returning a "real" null would break the deterministic identifier: the values are .sorted() and then joined, and sorted() throws on nulls. The literal "null" keeps it stable and safe for comparison/concatenation. We could switch to real nulls only if we add null-safe sorting/joining.
|
|
||
| private static String describeChannel(Channel channel, boolean isSourceChannel) { | ||
| if (channel == null) { | ||
| return "null"; |
Contributor
There was a problem hiding this comment.
Same as the comment about null on other describeX above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separates determinism fixes/tests from Spark DataFrames work. Cherry-picks commits 7bcf2ff and 93fbadb from PR #647.
solves #634