Skip to content

Some ASCII-safe constants as byte[] to obviate ASCII-check #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DanskerDave
Copy link

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2022

Codecov Report

Attention: Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.

Project coverage is 58.54%. Comparing base (0d5a278) to head (9607142).
Report is 368 commits behind head on master.

Files with missing lines Patch % Lines
...ava/org/apache/axiom/mime/MultipartBodyWriter.java 85.18% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
+ Coverage   58.52%   58.54%   +0.02%     
==========================================
  Files         515      515              
  Lines       14794    14807      +13     
  Branches     2553     2555       +2     
==========================================
+ Hits         8658     8669      +11     
- Misses       5539     5540       +1     
- Partials      597      598       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@veithen
Copy link
Member

veithen commented Nov 20, 2022

Is this change motivated by profiling, i.e. does it address an actual performance issue?

@DanskerDave
Copy link
Author

Is this change motivated by profiling, i.e. does it address an actual performance issue?

Well, it will make it a tad faster, by not checking that Strings known to be pure ASCII, really are ASCII.

Having them compiled as byte[] will save a bit too.

My Climate-Change contribution to save the planet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants